-
-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make mechanical properties a function of stoichiometry and sometimes temperature #3576
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3576 +/- ##
===========================================
- Coverage 99.59% 99.58% -0.01%
===========================================
Files 257 257
Lines 20639 20661 +22
===========================================
+ Hits 20556 20576 +20
- Misses 83 85 +2 ☔ View full report in Codecov by Sentry. |
I could be wrong, but it's hard for me to imagine how these regressions could be related to this PR |
The benchmarks on PRs are not reliable a lot of the times especially on GitHub Actions runners, it's usually good to re-run them if there is a chance of a regression being introduced |
I mean, I don't think these regressions are even running any of my code -- can someone rerun please if this is blocking? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, please update changelog
Omega = domain_param.Omega | ||
#use a tangential approximation for omega | ||
sto = variables[f"{Domain} particle concentration"] | ||
Omega = pybamm.r_average(domain_param.Omega(sto)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
while we're here, could Omega also depend on T?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, that would be a thermal expansion coefficient, generally called α
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean I guess they're the same thing really, but in some ways that's an entirely different model.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll do it anyway
Description
For many chemistries, notably high-nickel NMCs and graphite, the volume change associated with intercalation is a strong function of stoichiometry. Here, I have taken the r-averaged value for Ω and used it to calculate total stress. This accounts for the change without violating the initial model assumptions.
This is the same as #2943 but it was easier to start over than just update that one
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all
(or$ nox -s tests
)$ python run-tests.py --doctest
(or$ nox -s doctests
)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick
(or$ nox -s quick
).Further checks: