Fix switch to ruff format

[Rjchauhan18]

Description

• Changes made in pre-commit-config.yaml file

      - id: ruff-format
        args: [--check]

Fixes # (issue)

This PR will fixes the issue #3477

Type of change

• New feature (non-breaking change which adds functionality)
• Optimization (back-end change that speeds up the code)
• Bug fix (non-breaking change which fixes an issue)

Further checks:

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[Rjchauhan18]

Hey @Saransh-cpp
I am interested to doing this but starting 3rd nov, 2023 my exams are starting so i might not able to spend time solving issue till 9th nov, 2023 .

so till then if someone solve this with you then fine otherwise i will come back on 9th still you can review it give me the comments what changes you want if i am quickly able to change those thing then i will otherwise i wll come on 9th nov .

[Rjchauhan18]

And one more thing do you want it to auto fix everything or just check?

[Saransh-cpp]

Sounds good! We should autofix everything.

[Rjchauhan18]

Now pre-commit bot will auto commit everything which can be change

[Saransh-cpp]

Thanks, @Rjchauhan18! You should also add pre-commit's commit's hash in https://github.com/pybamm-team/PyBaMM/blob/develop/.git-blame-ignore-revs

[Saransh-cpp]

Suggested change

	- id: ruff-format
	- id: ruff-format
	types_or: [python, pyi, jupyter]

[Rjchauhan18]

  - repo: https://github.com/astral-sh/ruff-pre-commit
    rev: "v0.1.3"
    hooks:
      - id: ruff
        args: [--fix, --show-fixes]
   

      - id: ruff-format
        types_or: [python, pyi, jupyter]

It is removing ; from .ipynb

[kratman]

I think a lot of the semi-colons just stop output like:

<pybamm.solvers.solution.Solution at 0x13cc02f10>

This does not seem like a huge problem.

Another way to resolve that printing is to save output objects to a discarded variable:

_ = sim.solve()

instead of

sim.solve();

[Rjchauhan18]

yes, _ = sim.solve() this is in the jupyter notebook

But for plotting graphs without line like this [<matplotlib.lines.Line2D at 0x7f4123ea7ac0>] we need semi-colons.

---

One Solution is to put # fmt: off and # fmt: on where semi-colons appear

# fmt: off
plt.plot(sol["Time [s]"].data, sol["Voltage [V]"].data);
# fmt: on

Should I use these comments or try to find something else?

[kratman]

Personally I would prefer to avoid adding tool specific comments if there are other ways.

In this case:

_ = plt.plot(sol["Time [s]"].data, sol["Voltage [V]"].data)

works since plot() also has a return

[Rjchauhan18]

Hello @Saransh-cpp
which changes you prefer ?

[Saransh-cpp]

The semicolon thing was fixed in ruff upstream. You might have to reset your commits and introduce ruff format in an entirely new commit, given that we want all the pre-commit related changes bundled in a single commit.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d37a8f2) 99.58% compared to head (2ff87e1) 99.58%.
Report is 2 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #3492   +/-   ##
========================================
  Coverage    99.58%   99.58%           
========================================
  Files          256      256           
  Lines        20048    20048           
========================================
  Hits         19965    19965           
  Misses          83       83           

Files	Coverage Δ
pybamm/discretisations/discretisation.py	99.78% <ø> (ø)
pybamm/expression_tree/averages.py	100.00% <ø> (ø)
pybamm/expression_tree/binary_operators.py	100.00% <ø> (ø)
pybamm/expression_tree/concatenations.py	100.00% <ø> (ø)
pybamm/expression_tree/functions.py	100.00% <100.00%> (ø)
...mm/expression_tree/operations/convert_to_casadi.py	100.00% <ø> (ø)
pybamm/expression_tree/symbol.py	100.00% <ø> (ø)
pybamm/expression_tree/vector.py	100.00% <ø> (ø)
pybamm/input/parameters/lithium_ion/Ai2020.py	100.00% <100.00%> (ø)
pybamm/input/parameters/lithium_ion/Chen2020.py	100.00% <100.00%> (ø)
... and 35 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Saransh-cpp]

@Rjchauhan18 let us know if you need any help on this!

[Saransh-cpp]

Closing this PR as it went stale, and taking up the work in #3656