Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2860 fix bpx data interpolant #2957

Merged
merged 8 commits into from
May 26, 2023
Merged

#2860 fix bpx data interpolant #2957

merged 8 commits into from
May 26, 2023

Conversation

rtimms
Copy link
Contributor

@rtimms rtimms commented May 16, 2023

Description

Fixes a bug where all data included in a BPX was assumed to be given as a function of time.

Fixes #2914

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all
  • The documentation builds: $ python run-tests.py --doctest

You can run unit and doctests together at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@rtimms
Copy link
Contributor Author

rtimms commented May 16, 2023

Sorry, got the wrong issue number, d'oh! This fixes #2914, not #2860

@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Patch coverage: 94.33% and no project coverage change.

Comparison is base (7e681e2) 99.70% compared to head (0c2f416) 99.71%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2957   +/-   ##
========================================
  Coverage    99.70%   99.71%           
========================================
  Files          245      245           
  Lines        18659    18693   +34     
========================================
+ Hits         18604    18639   +35     
+ Misses          55       54    -1     
Impacted Files Coverage Δ
pybamm/parameters/bpx.py 94.44% <94.33%> (+1.76%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rtimms rtimms requested a review from martinjrobins May 16, 2023 14:38
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Sponsor Member

@brosaplanella brosaplanella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@rtimms rtimms merged commit 57d06db into develop May 26, 2023
@rtimms rtimms deleted the issue-2860-bpx-interp-bug branch May 26, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: BPX diffusivity interpolant issue
2 participants