Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #2457 make jupyter a dev only dependency #2846

Merged
merged 16 commits into from
Apr 3, 2023
Merged

Issue #2457 make jupyter a dev only dependency #2846

Show file tree
Hide file tree
Changes from 15 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
9c5fe35
Removed Jupyter from requirements.txt
arjxn-py Mar 30, 2023
1ba8b5c
Moved Jupyter from required deps to Dev Deps
arjxn-py Mar 30, 2023
8e5bd4c
Listed importlib-metadata as req dependency
arjxn-py Mar 30, 2023
ecade1e
Listed nbconvert as req dependency
arjxn-py Mar 30, 2023
1dec74e
Merge branch 'pybamm-team:develop' into Issue-#2457-Make-jupyter-a-de…
arjxn-py Apr 1, 2023
b0bcadd
installing jupyter in iox.ini
arjxn-py Apr 1, 2023
3b04513
installing jupyter in tox.ini
arjxn-py Apr 1, 2023
805199b
Merge branch 'Issue-#2457-Make-jupyter-a-dev-only-dependency' of http…
arjxn-py Apr 1, 2023
fbeec0d
installing jupyter to run example tests
arjxn-py Apr 1, 2023
9ac57de
make jupyter a dev dep in tox.ini
arjxn-py Apr 1, 2023
346b06b
Trying to resolve linux build error
arjxn-py Apr 2, 2023
7bb578c
made nbconvert a dev dependency
arjxn-py Apr 2, 2023
aa2744d
style: pre-commit fixes
pre-commit-ci[bot] Apr 2, 2023
976df86
removed explicit listing of nbconvert from tox.ini
arjxn-py Apr 2, 2023
68eb624
Apply suggestions from code review
arjxn-py Apr 2, 2023
ba89a07
Updated changelog for the same PR
arjxn-py Apr 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ autograd >= 1.2
scikit-fem >= 0.2.0
casadi >= 3.5.0
imageio>=2.9.0
jupyter # For example notebooks
pybtex>=0.24.0
sympy >= 1.8
bpx
Expand Down
3 changes: 2 additions & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ def compile_KLU():
"scikit-fem>=0.2.0",
"casadi>=3.5.0",
"imageio>=2.9.0",
"jupyter", # For example notebooks
"importlib-metadata",
"pybtex>=0.24.0",
"sympy>=1.8",
"bpx",
Expand All @@ -218,6 +218,7 @@ def compile_KLU():
"dev": [
"pre-commit", # For code style checking
"black", # For code style auto-formatting
"jupyter", # For example notebooks
],
},
entry_points={
Expand Down
1 change: 1 addition & 0 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ deps =
doctests: sphinx-copybutton
doctests: myst-parser
!windows-!mac: scikits.odes
examples: jupyter # For example notebooks

commands =
tests-!windows-!mac: sh -c "pybamm_install_jax" # install jax, jaxlib for ubuntu
Expand Down