Electrode soh from c

[valentinsulzer]

Description

Reformat electrode SOH a little bit, reducing duplicate code where possible.
Breaking changes:

• renamed cap_init to Q_init
• renamed inputs for electrode SOH calculations
• changed input from n_Li to Q_Li for electrode SOH calculations

Added option to calculate initial stoichiometries from cell capacity (instead of cyclable lithium capacity), and/or from target voltage

Fixes # (issue)

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

• New feature (non-breaking change which adds functionality)
• Optimization (back-end change that speeds up the code)
• Bug fix (non-breaking change which fixes an issue)

Key checklist:

• No style issues: $ flake8
• All tests pass: $ python run-tests.py --unit
• The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[codecov]

Codecov Report

Base: 99.72% // Head: 99.72% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (8076c44) compared to base (3961286).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #2508   +/-   ##
========================================
  Coverage    99.72%   99.72%           
========================================
  Files          270      270           
  Lines        19423    19487   +64     
========================================
+ Hits         19370    19434   +64     
  Misses          53       53           

Impacted Files	Coverage Δ
pybamm/models/base_model.py	98.48% <ø> (ø)
...models/full_battery_models/lithium_ion/__init__.py	100.00% <ø> (ø)
...ttery_models/lithium_ion/base_lithium_ion_model.py	100.00% <100.00%> (ø)
..._battery_models/lithium_ion/basic_dfn_half_cell.py	99.01% <100.00%> (ø)
...s/full_battery_models/lithium_ion/electrode_soh.py	100.00% <100.00%> (ø)
...tery_models/lithium_ion/electrode_soh_half_cell.py	100.00% <100.00%> (ø)
pybamm/parameters/base_parameters.py	100.00% <100.00%> (ø)
pybamm/parameters/lithium_ion_parameters.py	100.00% <100.00%> (ø)
pybamm/parameters/parameter_values.py	100.00% <100.00%> (ø)
pybamm/simulation.py	100.00% <100.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[rtimms]

thanks @tinosulzer !