Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 2334 reformat parameters #2342

Merged
merged 32 commits into from
Oct 11, 2022
Merged
Show file tree
Hide file tree
Changes from 30 commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
251b85a
add script to convert csv parameters to python file
valentinsulzer Sep 30, 2022
4d8c229
#2334 working on loading new-style parameters
valentinsulzer Oct 1, 2022
69324c5
#2334 make printing python a method of ParameterValues
valentinsulzer Oct 3, 2022
e96ec5d
add readmes and better parameter files to generated python scripts
valentinsulzer Oct 3, 2022
ff344a8
#2334 fix load_function
valentinsulzer Oct 4, 2022
0d56ecf
#2334 fixing tests
valentinsulzer Oct 4, 2022
2a75a8d
style: pre-commit fixes
pre-commit-ci[bot] Oct 4, 2022
7f05564
#2334 more test fixes
valentinsulzer Oct 4, 2022
4e9469a
merge
valentinsulzer Oct 4, 2022
4b13ab0
#2334 tests
valentinsulzer Oct 4, 2022
aa5d84e
trying to fix coverage issue
valentinsulzer Oct 5, 2022
62eb4b3
#2334 remove old parameters and clean up readmes
valentinsulzer Oct 5, 2022
e40e21d
#2334 fixing tests
valentinsulzer Oct 5, 2022
1bf5896
Merge branch 'develop' into issue-2334-reformat-parameters
valentinsulzer Oct 5, 2022
a05ac21
#2334 tests
valentinsulzer Oct 5, 2022
25a12ce
#2334 still testing
valentinsulzer Oct 5, 2022
ab551d4
#2334 fix parameter_values tests
valentinsulzer Oct 5, 2022
090cc1f
#2334 fix landesfeind
valentinsulzer Oct 5, 2022
fbe4a2b
#2334 integration tests
valentinsulzer Oct 6, 2022
8c2d561
#2334 working on example tests, undelete update_parameter_sets_doc.py
valentinsulzer Oct 6, 2022
f7ca03a
#2334 fix test, try full path in codecov.yml
valentinsulzer Oct 6, 2022
60bdd60
#2334 changelog
valentinsulzer Oct 6, 2022
5051cd4
move generated parameter file outside of pybamm dir
valentinsulzer Oct 6, 2022
f73ddd5
flake8
valentinsulzer Oct 6, 2022
7abfe84
#2334 coverage
valentinsulzer Oct 6, 2022
a526810
#2334 flake8
valentinsulzer Oct 6, 2022
1fbf2a9
#2334 fix duplicated name
valentinsulzer Oct 6, 2022
778a8d5
#2334 coverage
valentinsulzer Oct 6, 2022
f014848
#2334 fix lead-acid tests
valentinsulzer Oct 7, 2022
408db86
#2334 fix example
valentinsulzer Oct 7, 2022
c2b6537
merge develop
valentinsulzer Oct 10, 2022
c3b0676
#2334 ferran and rob comments
valentinsulzer Oct 10, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
1 change: 0 additions & 1 deletion .github/codecov.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
ignore:
- pybamm/parameters_cli.py
- pybamm/install_odes.py
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@

- For simulations with events that cause the simulation to stop early, the sensitivities could be evaluated incorrectly to zero ([#2331](https://github.com/pybamm-team/PyBaMM/pull/2337))

## Breaking change

- Removed parameter cli tools (add/edit/remove parameters). Parameter sets can now more easily be added via python scripts. ([#2342](https://github.com/pybamm-team/PyBaMM/pull/2342))
- Parameter sets should now be provided as single python files containing all parameters and functions. Parameters provided as "data" (e.g. OCP vs SOC) can still be csv files, but must be either in the same folder as the parameter file or in a subfolder called "data/". See for example [Ai2020](https://github.com/pybamm-team/PyBaMM/tree/develop/pybamm/input/parameters/lithium_ion/Ai2020.py) ([#2342](https://github.com/pybamm-team/PyBaMM/pull/2342))

# [v22.9](https://github.com/pybamm-team/PyBaMM/tree/v22.9) - 2022-09-30

## Features
Expand Down
1 change: 0 additions & 1 deletion docs/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ API documentation
source/util
source/callbacks
source/citations
source/parameters_cli
source/batch_study

Examples
Expand Down
19 changes: 0 additions & 19 deletions docs/source/parameters_cli.rst

This file was deleted.

Loading