Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix to OKane2022 temperature dependence in positive electrode #2309

Merged
merged 3 commits into from
Sep 21, 2022

Conversation

DrSOKane
Copy link
Contributor

Description

Previously, the parameters.csv for nmc_OKane2022 did not point to the Arrhenius function I wrote for the diffusivity. This PR fixes this.

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Base: 99.63% // Head: 99.63% // No change to project coverage 👍

Coverage data is based on head (43a9ab6) compared to base (96e57ec).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2309   +/-   ##
========================================
  Coverage    99.63%   99.63%           
========================================
  Files          362      362           
  Lines        20035    20035           
========================================
  Hits         19962    19962           
  Misses          73       73           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@valentinsulzer valentinsulzer merged commit f5d16bc into pybamm-team:develop Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants