Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make variables_and_events attribute and remove some events #2158

Merged
merged 4 commits into from
Jul 11, 2022

Conversation

valentinsulzer
Copy link
Member

Description

Some changes to help debugging events

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Jul 7, 2022

Codecov Report

Merging #2158 (361cc79) into develop (6877eac) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #2158   +/-   ##
========================================
  Coverage    99.38%   99.38%           
========================================
  Files          356      356           
  Lines        19297    19309   +12     
========================================
+ Hits         19178    19190   +12     
  Misses         119      119           
Impacted Files Coverage Δ
pybamm/models/base_model.py 99.27% <100.00%> (+0.01%) ⬆️
...ls/electrolyte_diffusion/constant_concentration.py 100.00% <100.00%> (ø)
...amm/models/submodels/porosity/constant_porosity.py 100.00% <100.00%> (ø)
pybamm/solvers/solution.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6877eac...361cc79. Read the comment docs.

@valentinsulzer valentinsulzer merged commit 1cd386d into develop Jul 11, 2022
@valentinsulzer valentinsulzer deleted the events-in-variables branch July 11, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants