Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add example for combinations of models and parameters #2112

Merged
merged 7 commits into from
Aug 3, 2022

Conversation

valentinsulzer
Copy link
Member

Description

Adds example to loop through all combinations of models and parameters and print whether that model can be parameterized by those parameters

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #2112 (1ba86e7) into develop (59c99b2) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #2112      +/-   ##
===========================================
- Coverage    99.36%   99.36%   -0.01%     
===========================================
  Files          355      355              
  Lines        19514    19489      -25     
===========================================
- Hits         19390    19365      -25     
  Misses         124      124              
Impacted Files Coverage Δ
...m/models/full_battery_models/base_battery_model.py 99.76% <100.00%> (+<0.01%) ⬆️
pybamm/util.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Sponsor Member

@brosaplanella brosaplanella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks @tinosulzer!

@valentinsulzer valentinsulzer merged commit 3c7ad7c into develop Aug 3, 2022
@valentinsulzer valentinsulzer deleted the model-parameter-combos branch August 3, 2022 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants