Code

SEI on cracks#2104

Code

Merged

valentinsulzer merged 42 commits intopybamm-team:developpybamm-team/PyBaMM:developfrom DrSOKane:SEIoncracksDrSOKane/PyBaMM:SEIoncracksCopy head branch name to clipboardJul 27, 2022

+1,458-255

Commits

Commits on Apr 27, 2022

• Partially completed first draft of SEI on cracks

  

  DrSOKane

  committed
  b27ae28

  Copy full SHA for b27ae28

Commits on Apr 28, 2022

• Second attempt at adding SEI on cracks

  

  DrSOKane

  committed
  23a0a6f

  Copy full SHA for 23a0a6f

Commits on May 12, 2022

• Fixed some bugs in crack SEI model

  

  DrSOKane

  committed
  d17473a

  Copy full SHA for d17473a

Commits on May 18, 2022

• Ensure loss of lithium to SEI on cracks is always defined

  

  DrSOKane

  committed
  e105d40

  Copy full SHA for e105d40

Commits on Jun 14, 2022

• Replaced most references to 'SEI' and 'SEI on cracks' with self.reaction

  

  DrSOKane

  committed
  e4d93d8

  Copy full SHA for e4d93d8

Commits on Jun 15, 2022

• Changed L_n to n.L

  

  DrSOKane

  committed
  e36602b

  Copy full SHA for e36602b

Commits on Jun 20, 2022

• Added NoMechanics subclass

  

  DrSOKane

  committed
  ecfcdc4

  Copy full SHA for ecfcdc4

• flake8

  

  DrSOKane

  committed
  fea7d4c

  Copy full SHA for fea7d4c

Commits on Jun 21, 2022

• Added if statement to set roughness to 1 if not in variables

  

  DrSOKane

  committed
  5b321a7

  Copy full SHA for 5b321a7

Commits on Jun 22, 2022

• Revert "Added if statement to set roughness to 1 if not in variables"

  Show description for 6bfddd1
  

  DrSOKane

  committed
  6bfddd1

  Copy full SHA for 6bfddd1

• Merge branch 'develop' into SEIoncracks

  

  DrSOKane

  committed
  3fb424a

  Copy full SHA for 3fb424a

• Added cracking parameters to graphite_Chen2020_plating

  

  DrSOKane

  committed
  775626f

  Copy full SHA for 775626f

Commits on Jun 23, 2022

• Added get_coupled_variables to NoSEI class

  

  DrSOKane

  committed
  0ad8afe

  Copy full SHA for 0ad8afe

Commits on Jun 24, 2022

• Cracking model works but OKane2022 parameters do not

  

  DrSOKane

  committed
  a21484d

  Copy full SHA for a21484d

Commits on Jun 29, 2022

• Added Arrhenius temperature dependence to all SEI growth models

  

  DrSOKane

  committed
  7ec5fc8

  Copy full SHA for 7ec5fc8

• Merge branch 'develop' of https://github.com/pybamm-team/PyBaMM into SEIoncracks

  

  DrSOKane

  committed
  274439d

  Copy full SHA for 274439d

Commits on Jul 13, 2022

• Added zero temperature dependence for all other SEI parameter sets

  

  DrSOKane

  committed
  e106c1d

  Copy full SHA for e106c1d

Commits on Jul 15, 2022

• Completed example notebook

  

  DrSOKane

  committed
  82d5800

  Copy full SHA for 82d5800

• Updated with latest changes from upstream

  

  DrSOKane

  committed
  17725e5

  Copy full SHA for 17725e5

• Updated CHANGELOG

  

  DrSOKane

  committed
  3dc6375

  Copy full SHA for 3dc6375

Commits on Jul 18, 2022

• flake8

  

  DrSOKane

  committed
  c78229a

  Copy full SHA for c78229a

Commits on Jul 19, 2022

• Fixed get_coupled_variables in no_sei.py

  

  DrSOKane

  committed
  6e7fbcf

  Copy full SHA for 6e7fbcf

• Changed base_lithium_ion_model to avoid running SEI on cracks for half-cell case

  

  DrSOKane

  committed
  0a93993

  Copy full SHA for 0a93993

• flake8

  

  DrSOKane

  committed
  2ddb0c2

  Copy full SHA for 2ddb0c2

Commits on Jul 20, 2022

• Fixed bug in equation for interstitial-diffusion limited SEI

  

  DrSOKane

  committed
  0080825

  Copy full SHA for 0080825

• Fixed examples, added SEI on cracks porosity change, added tests

  

  DrSOKane

  committed
  c628f95

  Copy full SHA for c628f95

• flake8

  

  DrSOKane

  committed
  f23b3ba

  Copy full SHA for f23b3ba

Commits on Jul 21, 2022

• Breaking change: particle mechanics now a compulsory submodel (none is acceptable)

  

  DrSOKane

  committed
  5f0258e

  Copy full SHA for 5f0258e

• coverage

  

  DrSOKane

  committed
  7ee18d8

  Copy full SHA for 7ee18d8

• Fixed tests

  

  DrSOKane

  committed
  1d6319e

  Copy full SHA for 1d6319e

Commits on Jul 22, 2022

• Merged latest changes from develop to fix conflict

  

  DrSOKane

  committed
  ffdbb48

  Copy full SHA for ffdbb48

• Fixed test_OKane2022

  

  DrSOKane

  committed
  f6b979f

  Copy full SHA for f6b979f

• flake8

  

  DrSOKane

  committed
  5ae0a6c

  Copy full SHA for 5ae0a6c

Commits on Jul 26, 2022

• Completed changes requested in review

  

  DrSOKane

  committed
  63a9c79

  Copy full SHA for 63a9c79

• changelog

  

  DrSOKane

  committed
  21f0374

  Copy full SHA for 21f0374

• Modified tests to account for Chen2020_plating being deleted

  

  DrSOKane

  committed
  4153103

  Copy full SHA for 4153103

• Modified more tests to account for Chen2020_plating being deleted

  

  DrSOKane

  committed
  9ad8b75

  Copy full SHA for 9ad8b75

• Hard coded cracking activation energy (currently 0)

  

  DrSOKane

  committed
  ebeffb1

  Copy full SHA for ebeffb1

Commits on Jul 27, 2022

• Removed cracking activation energy from parameter csv files

  

  DrSOKane

  committed
  51d1c4f

  Copy full SHA for 51d1c4f

• Deleted the correct parameter this time

  

  DrSOKane

  committed
  851b44c

  Copy full SHA for 851b44c

• Third time lucky?

  

  DrSOKane

  committed
  2b77c81

  Copy full SHA for 2b77c81

• Fixed conflict in changelog

  

  DrSOKane

  committed
  5276a9b

  Copy full SHA for 5276a9b