Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DFN with particle size distributions #1602

Merged
merged 22 commits into from
Aug 24, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
# [Unreleased](https://github.com/pybamm-team/PyBaMM)

## Features

- Added submodels and functionality for particle-size distributions in the DFN model, including an
example notebook ([#1602](https://github.com/pybamm-team/PyBaMM/pull/1602))
- Added UDDS and WLTC drive cycles ([#1601](https://github.com/pybamm-team/PyBaMM/pull/1601))
- `pybamm.base_solver.solve` function can take a list of input parameters to calculate the sensitivities of the solution with respect to. Alternatively, it can be set to `True` to calculate the sensitivities for all input parameters ([#1552](https://github.com/pybamm-team/PyBaMM/pull/1552))
- Addes UDDS and WLTC drive cycles ([#1601](https://github.com/pybamm-team/PyBaMM/pull/1601))
- Added capability for `quaternary` domains (in addition to `primary`, `secondary` and `tertiary`), increasing the maximum number of domains that a `Symbol` can have to 4. ([#1580](https://github.com/pybamm-team/PyBaMM/pull/1580))
- Tabs can now be placed at the bottom of the cell in 1+1D thermal models ([#1581](https://github.com/pybamm-team/PyBaMM/pull/1581))
- Added temperature dependence on electrode electronic conductivity ([#1570](https://github.com/pybamm-team/PyBaMM/pull/1570))
Expand Down Expand Up @@ -42,7 +43,7 @@
- Made parameters importable through pybamm ([#1475](https://github.com/pybamm-team/PyBaMM/pull/1475))

## Breaking changes

- Refactored the `particle` submodel module, with the models having no size distribution now found in `particle.no_distribution`, and those with a size distribution in `particle.size_distribution`. Renamed submodels to indicate the transport model (Fickian diffusion, polynomial profile) and if they are "x-averaged". E.g., `FickianManyParticles` and `FickianSingleParticle` are now `no_distribution.FickianDiffusion` and `no_distribution.XAveragedFickianDiffusion` ([#1602](https://github.com/pybamm-team/PyBaMM/pull/1602))
- Changed sensitivity API. Removed `ProcessedSymbolicVariable`, all sensitivity now handled within the solvers and `ProcessedVariable` () ([#1552](https://github.com/pybamm-team/PyBaMM/pull/1552))
- The `Yang2017` parameter set has been removed as the complete parameter set is not publicly available in the literature ([#1577](https://github.com/pybamm-team/PyBaMM/pull/1577))
- Changed how options are specified for the "loss of active material" and "particle cracking" submodels. "loss of active material" can now be one of "none", "stress-driven", or "reaction-driven", or a 2-tuple for different options in negative and positive electrode. Similarly "particle cracking" (now called "particle mechanics") can now be "none", "swelling only", "swelling and cracking", or a 2-tuple ([#1490](https://github.com/pybamm-team/PyBaMM/pull/1490))
Expand Down

This file was deleted.

This file was deleted.

5 changes: 1 addition & 4 deletions docs/source/models/submodels/particle/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,5 @@ Particle
:maxdepth: 1

base_particle
fickian_single_particle
fickian_many_particles
polynomial_single_particle
polynomial_many_particles
no_distribution/index
size_distribution/index
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Fickian Diffusion
=================

.. autoclass:: pybamm.particle.no_distribution.FickianDiffusion
:members:


10 changes: 10 additions & 0 deletions docs/source/models/submodels/particle/no_distribution/index.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
No Particle-Size Distribution
=============================

.. toctree::
:maxdepth: 1

fickian_diffusion
x_averaged_fickian_diffusion
polynomial_profile
x_averaged_polynomial_profile
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Polynomial Profile
==================

.. autoclass:: pybamm.particle.no_distribution.PolynomialProfile
:members:
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
X-averaged Fickian Diffusion
============================

.. autoclass:: pybamm.particle.no_distribution.XAveragedFickianDiffusion
:members:

Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
X-averaged Polynomial Profile
=============================

.. autoclass:: pybamm.particle.no_distribution.XAveragedPolynomialProfile
:members:

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Particle Size Distribution Base Model
=====================================

.. autoclass:: pybamm.particle.BaseSizeDistribution
.. autoclass:: pybamm.particle.size_distribution.BaseSizeDistribution
:members:

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Fickian Diffusion
=================

.. autoclass:: pybamm.particle.size_distribution.FickianDiffusion
:members:


This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,7 @@ Particle Size Distribution
:maxdepth: 1

base_distribution
fickian_single_distribution
fast_single_distribution
fickian_diffusion
x_averaged_fickian_diffusion
uniform_profile
x_averaged_uniform_profile
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Uniform Profile
===============

.. autoclass:: pybamm.particle.size_distribution.UniformProfile
:members:
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
X-averaged Fickian Diffusion
============================

.. autoclass:: pybamm.particle.size_distribution.XAveragedFickianDiffusion
:members:

Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
X-averaged Uniform Profile
==========================

.. autoclass:: pybamm.particle.size_distribution.XAveragedUniformProfile
:members:
497 changes: 497 additions & 0 deletions examples/notebooks/models/DFN-with-particle-size-distributions.ipynb

Large diffs are not rendered by default.

Loading