Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add udds #1601

Merged
merged 3 commits into from
Aug 10, 2021
Merged

Add udds #1601

merged 3 commits into from
Aug 10, 2021

Conversation

valentinsulzer
Copy link
Member

Description

Adds UDDS and WLTC drive cycles

Fixes #1264
Fixes #1599

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Aug 9, 2021

Codecov Report

Merging #1601 (1ce0a10) into develop (4ebecbc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1601   +/-   ##
========================================
  Coverage    97.92%   97.92%           
========================================
  Files          324      324           
  Lines        18150    18150           
========================================
  Hits         17773    17773           
  Misses         377      377           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ebecbc...1ce0a10. Read the comment docs.

Copy link
Contributor

@rtimms rtimms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @tinosulzer !

pybamm/input/drive_cycles/WLTC.csv Show resolved Hide resolved
@valentinsulzer valentinsulzer merged commit 1ef394e into develop Aug 10, 2021
@valentinsulzer valentinsulzer deleted the add-UDDS branch September 13, 2021 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UDDS loading profile Use of WLTC drive cycle
2 participants