Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.4.0 release #1448

Merged
merged 838 commits into from
Mar 29, 2021
Merged

v0.4.0 release #1448

merged 838 commits into from
Mar 29, 2021

Conversation

valentinsulzer
Copy link
Member

v0.4.0 release

allcontributors bot and others added 30 commits February 11, 2021 18:54
@allcontributors
docs: update README.md [skip ci]
341fc82
@allcontributors
docs: update .all-contributorsrc [skip ci]
7ee156c
@valentinsulzer
Merge pull request #1379 from pybamm-team/all-contributors/add-priyan…
facdf0c 
…shuone6

docs: add priyanshuone6 as a contributor
@DavidMStraub
Remove OCV from ECM resistance definition
a0c63b7
@DavidMStraub
Simplify ECM overvoltage
7b7719d
@allcontributors
docs: update README.md [skip ci]
35c6638
@allcontributors
docs: update .all-contributorsrc [skip ci]
0950000
@priyanshuone6
run black and flake8
5558d47
@valentinsulzer
Merge pull request #1378 from tlestang/develop
92d0279 
Make benchmark_on_push pass for merge commits on develop
@asinghgaba
Fix PEP stlying for pybamm/experiments/*
18e184d
@asinghgaba
Fix PEP stlying for pybamm/expression_tree/*
9d1c348
@asinghgaba
Fix PEP stlying for pybamm/models/*
f2aefa4
@asinghgaba
Fix PEP stlying for pybamm/parameters/*
7c83503
@asinghgaba
Fix PEP stlying for pybamm/solvers/*
4dd30fa
@asinghgaba
Fix PEP stlying for pybamm/plotting/*
fee7659
@asinghgaba
Fix PEP stlying for pybamm/*
ecc5f9f
@asinghgaba
Fix PEP stlying for tests/*
9e0ab59
@valentinsulzer
Merge pull request #1382 from priyanshuone6/style-patch
5104541 
run black and flake8
update parameter_sets
c4928c0
@valentinsulzer
Merge pull request #1384 from pybamm-team/create-pull-request/patch-5…
51a9802 
…104541

Update parameter_sets.py docstring
@valentinsulzer
Merge pull request #1383 from asinghgaba/pep_fix
01b3e9a 
#1376 Fixed PEP styling around docstrings
@valentinsulzer
Merge pull request #1380 from DavidMStraub/ecm_resistance
b448b53 
Remove OCV from ECM resistance definition
@valentinsulzer
Merge pull request #1381 from pybamm-team/all-contributors/add-DavidM…
2f51eaa 
…Straub

docs: add DavidMStraub as a contributor
@priyanshuone6
add push to develop
477652d
@priyanshuone6
add extra indent
6552ac0
@priyanshuone6
update parameter_sets docstring
fa3a9d7
@priyanshuone6
update parameter_sets docstring
dbaebc8
@priyanshuone6
fix workflow and update parameter_sets
a4b46fe
@priyanshuone6
update tests
cead478
@valentinsulzer
Merge pull request #1387 from priyanshuone6/ps-fix
4861b82 
Fix workflow and update_parameter_sets.py
@codecov
Copy link

codecov bot commented Mar 26, 2021 •
edited
Loading

Codecov Report

Merging #1448 (4df4220) into main (903b4a0) will increase coverage by 0.28%.
The diff coverage is 99.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1448      +/-   ##
==========================================
+ Coverage   97.99%   98.28%   +0.28%     
==========================================
  Files         264      281      +17     
  Lines       14748    16219    +1471     
==========================================
+ Hits        14453    15941    +1488     
+ Misses        295      278      -17
Impacted Files Coverage Δ
...ybamm/expression_tree/operations/unpack_symbols.py 100.00% <ø> (ø)
pybamm/geometry/geometry.py 100.00% <ø> (ø)
...er2019/lead_exchange_current_density_Sulzer2019.py 100.00% <ø> (ø)
...ve_electrodes/lead_Sulzer2019/lead_ocp_Bode1977.py 100.00% <ø> (ø)
...ead_dioxide_exchange_current_density_Sulzer2019.py 100.00% <ø> (ø)
...ad_dioxide_Sulzer2019/lead_dioxide_ocp_Bode1977.py 100.00% <ø> (ø)
...2019/oxygen_exchange_current_density_Sulzer2019.py 100.00% <ø> (ø)
...s/graphite_Ai2020/graphite_cracking_rate_Ai2020.py 100.00% <ø> (ø)
...aphite_Ai2020/graphite_diffusivity_Dualfoil1998.py 100.00% <ø> (ø)
...s/graphite_Ai2020/graphite_volume_change_Ai2020.py 100.00% <ø> (ø)
... and 178 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 903b4a0...4df4220. Read the comment docs.

This was referenced Mar 27, 2021
Merged
Merged
rtimms
rtimms approved these changes Mar 27, 2021
View reviewed changes
Copy link
Contributor

@rtimms rtimms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @tinosulzer

brosaplanella
brosaplanella approved these changes Mar 27, 2021
View reviewed changes
Copy link
Member

@brosaplanella brosaplanella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@valentinsulzer
Copy link
Member Author

@tlestang feel free to merge this whenever so you can check the build and upload

@valentinsulzer valentinsulzer marked this pull request as draft March 27, 2021 22:02
@valentinsulzer valentinsulzer marked this pull request as ready for review March 27, 2021 23:53
@tlestang tlestang merged commit 1532185 into main Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtimms rtimms rtimms approved these changes

@brosaplanella brosaplanella brosaplanella approved these changes

@tlestang tlestang tlestang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@valentinsulzer @tlestang @brosaplanella @rtimms @DavidMStraub @priyanshuone6 @asinghgaba @KennethNwanoro @Saransh-cpp