Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1406 fixed bug with positive electrode ohmic losses #1407

Conversation

brosaplanella
Copy link
Sponsor Member

Description

Fixed the sign in the definition of positive electrode overpotential.

Fixes #1406

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Feb 27, 2021

Codecov Report

Merging #1407 (687dff4) into develop (2c223ba) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1407   +/-   ##
========================================
  Coverage    98.22%   98.22%           
========================================
  Files          278      278           
  Lines        15806    15806           
========================================
  Hits         15526    15526           
  Misses         280      280           
Impacted Files Coverage Δ
...ybamm/models/submodels/electrode/base_electrode.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c223ba...a7043df. Read the comment docs.

Copy link
Member

@valentinsulzer valentinsulzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks @brosaplanella

@brosaplanella brosaplanella merged commit 9a95deb into pybamm-team:develop Feb 28, 2021
@brosaplanella brosaplanella deleted the issue-1406-bug-positive-electrode-ohmic-losses branch February 28, 2021 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug positive electrode ohmic losses
2 participants