Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spectral volume reference #1348

Merged
merged 4 commits into from
Feb 1, 2021
Merged

Spectral volume reference #1348

merged 4 commits into from
Feb 1, 2021

Conversation

YannickNoelStephanKuhn
Copy link
Contributor

Description

Added the automated reference for Spectral Volumes to CITATIONS.txt. I'm sorry for just realizing now that I forgot it initially.

Should have been part of the merge for issue #900.

Type of change

Minor (no entry in CHANGELOG.md necessary).

Copy link
Sponsor Member

@brosaplanella brosaplanella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @YannickNoelStephanKuhn!

@YannickNoelStephanKuhn
Copy link
Contributor Author

All but the "build ubuntu" failed checks seem to be unrelated to my changes. In "build ubuntu", the error seems to indicate that the change to spectral_volume.py:Spectral_Volume's docstring is poorly formatted? I copy-pasted it from spectral_volume.py:cv_boundary_reconstruction_sub_matrix for consistency, but I'll remove it if it breaks something.

@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #1348 (8ab8de2) into develop (d90636a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1348   +/-   ##
========================================
  Coverage    98.15%   98.15%           
========================================
  Files          272      272           
  Lines        15577    15578    +1     
========================================
+ Hits         15289    15290    +1     
  Misses         288      288           
Impacted Files Coverage Δ
pybamm/spatial_methods/spectral_volume.py 98.11% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d90636a...15e9375. Read the comment docs.

@valentinsulzer valentinsulzer merged commit 7ab0c79 into pybamm-team:develop Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants