-
-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 1063 tplus temperature dependent #1317
Issue 1063 tplus temperature dependent #1317
Conversation
@tinosulzer if you can, take a look to the lead-acid part. I think I have implemented the same hack as with the other parameters, but I might have missed something. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @brosaplanella
Codecov Report
@@ Coverage Diff @@
## develop #1317 +/- ##
========================================
Coverage 98.11% 98.11%
========================================
Files 272 272
Lines 15339 15340 +1
========================================
+ Hits 15050 15051 +1
Misses 289 289
Continue to review full report at Codecov.
|
Happy for you to merge this, failing test is clearly just a github actions bug |
Description
The transference number
t_plus
is now a function of both electrolyte concentration and temperature. For lead-acid, the temperature dependence is ignored, as it happened with the other parameters.Fixes #1063
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: