Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ECM variables #1204

Merged
merged 2 commits into from
Oct 23, 2020
Merged

Add ECM variables #1204

merged 2 commits into from
Oct 23, 2020

Conversation

TomTranter
Copy link
Contributor

@TomTranter TomTranter commented Oct 21, 2020

Description

Some extra variables for the ecm model based on using pybamm in an external equivalent circuit model

Fixes # (issue)

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Oct 21, 2020

Codecov Report

Merging #1204 into develop will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1204   +/-   ##
========================================
  Coverage    97.93%   97.93%           
========================================
  Files          247      247           
  Lines        14024    14036   +12     
========================================
+ Hits         13734    13746   +12     
  Misses         290      290           
Impacted Files Coverage Δ
...m/models/full_battery_models/base_battery_model.py 99.67% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb9e793...1a59460. Read the comment docs.

Copy link
Contributor

@rtimms rtimms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good thanks, would you be able to reorganize this a little so that all the ECM variables are defined together and just add a short comment explaining them (its not obvious as we have no other ECM stuff in pybamm)

@TomTranter
Copy link
Contributor Author

@rtimms why failing on mac? I'm not authorized to merge this so please do so if you're ready. Thanks

@valentinsulzer
Copy link
Member

Everything is failing on mac right now. We need to wait for github to fix it

@valentinsulzer valentinsulzer merged commit 34fa6d7 into develop Oct 23, 2020
@valentinsulzer valentinsulzer deleted the add_ecm_variables branch October 23, 2020 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants