Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 983 half cell #1121

Merged
merged 46 commits into from
Aug 11, 2020
Merged

Issue 983 half cell #1121

merged 46 commits into from
Aug 11, 2020

Commits on Jun 27, 2020

  1. pybamm-team#983 started implementing half cell

    @brosaplanella
    brosaplanella committed Jun 27, 2020
    Configuration menu
    Copy the full SHA
    f35712b View commit details
    Browse the repository at this point in the history

  2. pybamm-team#983 continued implementation, still not working

    @brosaplanella
    brosaplanella committed Jun 27, 2020
    Configuration menu
    Copy the full SHA
    7ff2bd6 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2020

  1. pybamm-team#983 half cell running need debugging

    @brosaplanella
    brosaplanella committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    3ca7689 View commit details
    Browse the repository at this point in the history

  2. pybamm-team#893 removed lithium parameter set

    @brosaplanella
    brosaplanella committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    db733bc View commit details
    Browse the repository at this point in the history

  3. pybamm-team#983 debug and flake8

    @brosaplanella
    brosaplanella committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    4e31bf4 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2020

  1. pybamm-team#983 started implementing half cell

    @brosaplanella
    brosaplanella committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    e12a2b6 View commit details
    Browse the repository at this point in the history

  2. pybamm-team#983 continued implementation, still not working

    @brosaplanella
    brosaplanella committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    e3ca575 View commit details
    Browse the repository at this point in the history

  3. pybamm-team#983 half cell running need debugging

    @brosaplanella
    brosaplanella committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    e028d6b View commit details
    Browse the repository at this point in the history

  4. pybamm-team#893 removed lithium parameter set

    @brosaplanella
    brosaplanella committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    18f1376 View commit details
    Browse the repository at this point in the history

  5. pybamm-team#983 debug and flake8

    @brosaplanella
    brosaplanella committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    01c9ad4 View commit details
    Browse the repository at this point in the history

  6. pybamm-team#983 running half cell model

    @brosaplanella
    brosaplanella committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    450632f View commit details
    Browse the repository at this point in the history

  7. pybamm-team#983 started example running half cell experiment

    @brosaplanella
    brosaplanella committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    73b8e26 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2020

  1. pybamm-team#983 working example one GITT pulse

    @brosaplanella
    brosaplanella committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    f584712 View commit details
    Browse the repository at this point in the history

  2. pybamm-team#983 flake8

    @brosaplanella
    brosaplanella committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    6969f2f View commit details
    Browse the repository at this point in the history

  3. pybamm-team#983 remove old half cell model

    @brosaplanella
    brosaplanella committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    75cd138 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'issue-983-half-cell' of https://github.com/ferranbrosa/… 

    …PyBaMM into issue-983-half-cell
    @brosaplanella
    brosaplanella committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    29c21c4 View commit details
    Browse the repository at this point in the history

  5. 983 added discharge capacity

    @brosaplanella
    brosaplanella committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    12f049e View commit details
    Browse the repository at this point in the history

  6. pybamm-team#983 added Modulo operator

    @brosaplanella
    brosaplanella committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    de9c69d View commit details
    Browse the repository at this point in the history

  7. pybamm-team#983 use % symbol

    @brosaplanella
    brosaplanella committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    ce5be6d View commit details
    Browse the repository at this point in the history

  8. pybamm-team#983 flake8

    @brosaplanella
    brosaplanella committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    fab44a5 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2020

  1. pybamm-team#983 added multiple GITT pulses

    @brosaplanella
    brosaplanella committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    6a5221c View commit details
    Browse the repository at this point in the history

  2. pybamm-team#983 implement modulo events

    @brosaplanella
    brosaplanella committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    02a22cd View commit details
    Browse the repository at this point in the history

  3. flake8

    @brosaplanella
    brosaplanella committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    82967e4 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2020

  1. pybamm-team#983 started half cell test but needs debugging

    @brosaplanella
    brosaplanella committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    0e2a9b2 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2020

  1. pybamm-team#983 changed notation to positive and negative electrodes

    @brosaplanella
    brosaplanella committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    8247ba3 View commit details
    Browse the repository at this point in the history

  2. flake8

    @brosaplanella
    brosaplanella committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    6c9ccd6 View commit details
    Browse the repository at this point in the history

  3. pybamm-team#983 fix test

    @brosaplanella
    brosaplanella committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    40d49d6 View commit details
    Browse the repository at this point in the history

  4. pybamm-team#983 added copy and fixed tests

    @brosaplanella
    brosaplanella committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    b40c266 View commit details
    Browse the repository at this point in the history

  5. pybamm-team#983 added error if BasicDFNHalfCell ran with Simulations

    @brosaplanella
    brosaplanella committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    344c2fc View commit details
    Browse the repository at this point in the history

  6. pybamm-team#983 update example

    @brosaplanella
    brosaplanella committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    aea3fec View commit details
    Browse the repository at this point in the history

  7. pybamm-team#983 update CHANGELOG

    @brosaplanella
    brosaplanella committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    e2e6f55 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'develop' into issue-983-half-cell

    @brosaplanella
    brosaplanella committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    c9d63da View commit details
    Browse the repository at this point in the history

  9. flake8

    @brosaplanella
    brosaplanella committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    b55a0fa View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2020

  1. pybamm-team#983 add tests modulo

    @brosaplanella
    brosaplanella committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    b44d9cb View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2020

  1. pybamm-team#983 added floor and ceil operators

    @brosaplanella
    brosaplanella committed Aug 8, 2020
    Configuration menu
    Copy the full SHA
    3ca2d60 View commit details
    Browse the repository at this point in the history

  2. flake8

    @brosaplanella
    brosaplanella committed Aug 8, 2020
    Configuration menu
    Copy the full SHA
    fdd0bb3 View commit details
    Browse the repository at this point in the history

  3. pybamm-team#983 Tino's PR comments

    @brosaplanella
    brosaplanella committed Aug 8, 2020
    Configuration menu
    Copy the full SHA
    08884a0 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2020

  1. Merge branch 'develop' into issue-983-half-cell

    @brosaplanella
    brosaplanella committed Aug 10, 2020
    Configuration menu
    Copy the full SHA
    16b4ee8 View commit details
    Browse the repository at this point in the history

  2. pybamm-team#983 improve coverage

    @brosaplanella
    brosaplanella committed Aug 10, 2020
    Configuration menu
    Copy the full SHA
    61afe34 View commit details
    Browse the repository at this point in the history

  3. pybamm-team#983 add more Modulo tests to improve coverage

    @brosaplanella
    brosaplanella committed Aug 10, 2020
    Configuration menu
    Copy the full SHA
    6ea7f0a View commit details
    Browse the repository at this point in the history

  4. flake8

    @brosaplanella
    brosaplanella committed Aug 10, 2020
    Configuration menu
    Copy the full SHA
    65d7b59 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2020

  1. pybamm-team#983 added test events Modulo

    @brosaplanella
    brosaplanella committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    b4ecfbc View commit details
    Browse the repository at this point in the history

  2. pybamm-team#983 change default options to improve codacy

    @brosaplanella
    brosaplanella committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    a3e9f39 View commit details
    Browse the repository at this point in the history

  3. pybamm-team#983 undo previous change as it doesn't fix codacy

    @brosaplanella
    brosaplanella committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    9912c7a View commit details
    Browse the repository at this point in the history

  4. pybamm-team#983 added new test

    @brosaplanella
    brosaplanella committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    85a2e83 View commit details
    Browse the repository at this point in the history

  5. pybamm-team#983 Tino's second round of comments

    @brosaplanella
    brosaplanella committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    e296965 View commit details
    Browse the repository at this point in the history