Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1082 casadi sensitivity #1109

Merged
merged 22 commits into from
Jul 23, 2020
Merged

Conversation

valentinsulzer
Copy link
Member

@valentinsulzer valentinsulzer commented Jul 21, 2020

Description

Reformat casadi solver to allow sensitivities.
Sensitivity API will be reformatted in a subsequent PR.
Doesn't really fix issue #1082 so still leaving that open

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Jul 22, 2020

Codecov Report

Merging #1109 into develop will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1109   +/-   ##
========================================
  Coverage    97.82%   97.82%           
========================================
  Files          245      245           
  Lines        13269    13273    +4     
========================================
+ Hits         12980    12984    +4     
  Misses         289      289           
Impacted Files Coverage Δ
pybamm/simulation.py 96.81% <100.00%> (ø)
pybamm/solvers/base_solver.py 100.00% <100.00%> (ø)
pybamm/solvers/casadi_algebraic_solver.py 100.00% <100.00%> (ø)
pybamm/solvers/casadi_solver.py 100.00% <100.00%> (ø)
pybamm/solvers/processed_symbolic_variable.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b76042c...9b438ee. Read the comment docs.

Copy link
Contributor

@martinjrobins martinjrobins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @tinosulzer, looks great. My main comment is that the sensitivities api is currently quite different between the jax and casadi solvers, and ProcessedSymbolicVariable is very casadi specific, but we've already noted that and the plan is to iterate on the api to make it consistent.

Do you know how the sensitivities behave in the presence of an event? particularly if the location of the event changes in response to the symbolic variable?

@valentinsulzer
Copy link
Member Author

Yes, I'm reformatting the sensitivity API (getting rid of ProcessedSymbolicVariable) as part of #1100. Currently the model ignores events when doing sensitivity analysis. I can't think of a good way to handle events.

@valentinsulzer valentinsulzer merged commit e2e837b into develop Jul 23, 2020
@valentinsulzer valentinsulzer deleted the issue-1082-casadi-sensitivity branch August 10, 2020 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants