Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1096 fix sei typo #1097

Merged
merged 2 commits into from
Jul 1, 2020
Merged

#1096 fix sei typo #1097

merged 2 commits into from
Jul 1, 2020

Conversation

rtimms
Copy link
Contributor

@rtimms rtimms commented Jul 1, 2020

Description

Fixes a bug in interstitial_diffusion_limited.py

Fixes #1096

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Jul 1, 2020

Codecov Report

Merging #1097 into develop will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1097   +/-   ##
========================================
  Coverage    97.76%   97.76%           
========================================
  Files          243      243           
  Lines        12666    12667    +1     
========================================
+ Hits         12383    12384    +1     
  Misses         283      283           
Impacted Files Coverage Δ
...ls/interface/sei/interstitial_diffusion_limited.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33e695e...e1d956d. Read the comment docs.

@valentinsulzer valentinsulzer merged commit 56c0383 into develop Jul 1, 2020
@valentinsulzer valentinsulzer deleted the issue-1096-sei-bug branch July 1, 2020 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

j_sei in interstitial_diffusion_limited
2 participants