Issue 1082 casadi

[valentinsulzer]

Description

Some small changes to the casadi solver, particularly adding the events to the solution. Leaving the issue open as there is other stuff to do

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

• New feature (non-breaking change which adds functionality)
• Optimization (back-end change that speeds up the code)
• Bug fix (non-breaking change which fixes an issue)

Key checklist:

• No style issues: $ flake8
• All tests pass: $ python run-tests.py --unit
• The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[brosaplanella]

Looks good to me, thanks Tino!

[rtimms]

thanks @tinosulzer looks good, just a small comment re the error raised

[rtimms]

should we give the dimensional time in the error to make it easier for people to pass to t_eval. similar comment for dt_max

[codecov]

Codecov Report

Merging #1089 into develop will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #1089   +/-   ##
========================================
  Coverage    97.78%   97.78%           
========================================
  Files          242      242           
  Lines        12660    12662    +2     
========================================
+ Hits         12379    12381    +2     
  Misses         281      281           

Impacted Files	Coverage Δ
pybamm/solvers/casadi_solver.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4a57f8...ce4ca81. Read the comment docs.