Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1087 endpoints interpolate 2D #1088

Conversation

brosaplanella
Copy link
Member

Description

Fixed the interpolator for 2D processed variables so it can be evaluated at the boundaries of the domain.

Fixes #1087

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@brosaplanella brosaplanella requested review from rtimms and valentinsulzer and removed request for rtimms June 29, 2020 18:00
@codecov
Copy link

codecov bot commented Jun 29, 2020

Codecov Report

Merging #1088 into develop will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1088   +/-   ##
========================================
  Coverage    97.77%   97.78%           
========================================
  Files          242      242           
  Lines        12643    12660   +17     
========================================
+ Hits         12362    12379   +17     
  Misses         281      281           
Impacted Files Coverage Δ
pybamm/parameters/parameter_sets.py 100.00% <ø> (ø)
pybamm/solvers/processed_variable.py 99.61% <100.00%> (+0.02%) ⬆️
pybamm/solvers/solution.py 99.28% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc5d9f1...2d5f326. Read the comment docs.

@valentinsulzer valentinsulzer changed the base branch from develop to 2plus1D-paper-plots June 30, 2020 11:35
@valentinsulzer valentinsulzer changed the base branch from 2plus1D-paper-plots to develop June 30, 2020 11:36
Copy link
Member

@valentinsulzer valentinsulzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! And thank you for also fixing the points for the 2D plots :)

@valentinsulzer valentinsulzer merged commit a4a57f8 into pybamm-team:develop Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add endpoints interpolate 2D processed variable
2 participants