Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1066 add numpy function sqrt, sin, cos and exp to convert_to_casadi #1067

Merged
merged 7 commits into from
Jun 23, 2020

Conversation

martinjrobins
Copy link
Contributor

@martinjrobins martinjrobins commented Jun 22, 2020

Description

Fixes #1066

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Jun 22, 2020

Codecov Report

Merging #1067 into develop will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1067   +/-   ##
========================================
  Coverage    97.72%   97.72%           
========================================
  Files          237      237           
  Lines        12413    12435   +22     
========================================
+ Hits         12130    12152   +22     
  Misses         283      283           
Impacted Files Coverage Δ
pybamm/expression_tree/array.py 100.00% <100.00%> (ø)
pybamm/expression_tree/interpolant.py 100.00% <100.00%> (ø)
...mm/expression_tree/operations/convert_to_casadi.py 94.79% <100.00%> (+1.54%) ⬆️
pybamm/expression_tree/symbol.py 97.44% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17460e8...67f0fc1. Read the comment docs.

Copy link
Member

@valentinsulzer valentinsulzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @martinjrobins ! Merging

@valentinsulzer valentinsulzer merged commit 6c7a06e into develop Jun 23, 2020
@valentinsulzer valentinsulzer deleted the issue-1066-additional-casadi-funcitons branch June 23, 2020 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support additional numpy function in convert to casadi
2 participants