Make t and x dimensional in interpolation #920

valentinsulzer · 2020-03-26T15:20:30Z

For consistency of the user-facing interface, values supplied to a parameter when interpolating should always be dimensional.

rtimms mentioned this issue May 20, 2020

Faraday tech sessions #998

Closed

rtimms self-assigned this May 27, 2020

rtimms added a commit that referenced this issue May 27, 2020

#920 make calls to processed var dimensional

aafaa55

rtimms added a commit that referenced this issue May 28, 2020

#920 fix examples

7561597

rtimms added a commit that referenced this issue May 28, 2020

#920 debugging integration tests

347654c

rtimms added a commit that referenced this issue May 28, 2020

#920 fix most integration tests

98c06cb

rtimms added a commit that referenced this issue May 28, 2020

#920 fix convection tests

ad49ca7

rtimms mentioned this issue May 28, 2020

Issue 920 dimensional interp #1028

Merged

8 tasks

rtimms added a commit that referenced this issue May 29, 2020

#920 tino comments

af679e2

rtimms added a commit that referenced this issue May 29, 2020

#920 fix my typo in solver tols

b2b03dc

rtimms added a commit that referenced this issue May 29, 2020

#920 fix timescale

9169fcc

rtimms added a commit that referenced this issue May 29, 2020

#920 timescale with inputs

b494776

rtimms added a commit that referenced this issue May 29, 2020

#920 raise error if timescale depends on inputs

7572a09

rtimms closed this as completed in #1028 May 29, 2020

Provide feedback