Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow porosity to vary as function of x #802

Closed
valentinsulzer opened this issue Feb 5, 2020 · 0 comments · Fixed by #809
Closed

Allow porosity to vary as function of x #802

valentinsulzer opened this issue Feb 5, 2020 · 0 comments · Fixed by #809

Comments

@valentinsulzer
Copy link
Member

Summary
Specify porosity as a function of x in models

Motivation
Model graded electrodes, etc. If step function, need to be careful with how we discretise (easiest thing is to make sure to have an edge at the step change)
valentinsulzer added a commit that referenced this issue Feb 6, 2020
@valentinsulzer
#802 make porosity function of x
f50fcc4
valentinsulzer added a commit that referenced this issue Feb 7, 2020
@valentinsulzer
#802 fix basic dfn
e07b0c4
@valentinsulzer valentinsulzer mentioned this issue Feb 7, 2020
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 802 porosity pybamm-team/PyBaMM
1 participant
@valentinsulzer