Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify some objects on creation #709

Closed
valentinsulzer opened this issue Nov 6, 2019 · 0 comments · Fixed by #801
Closed

Simplify some objects on creation #709

valentinsulzer opened this issue Nov 6, 2019 · 0 comments · Fixed by #801

Comments

@valentinsulzer
Copy link
Member

One way to reduce the size of the tree and hence make simplify faster could be to have some simple rules for simplifying objects on creation. For example, Scalar(5) * Scalar(3) returns Scalar(15); similarly for Scalar * Array and Array @ Array.

Since we are now planning on having specific InputParameter objects, this would not cause any problems for parameter estimation. We just lose functionality of being able to update parameter values in an already-created model - so you have to specify up front which parameters you will want to update. This is probably something to do after implementing some kind of input parameter node though, just to be safe.

Thoughts?

valentinsulzer added a commit that referenced this issue Jan 31, 2020
valentinsulzer added a commit that referenced this issue Jan 31, 2020
valentinsulzer added a commit that referenced this issue Jan 31, 2020
valentinsulzer added a commit that referenced this issue Feb 1, 2020
valentinsulzer added a commit that referenced this issue Feb 1, 2020
valentinsulzer added a commit that referenced this issue Feb 1, 2020
valentinsulzer added a commit that referenced this issue Feb 3, 2020
valentinsulzer added a commit that referenced this issue Feb 3, 2020
valentinsulzer added a commit that referenced this issue Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant