-
-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broadcast to cell edges #609
Comments
valentinsulzer
added a commit
that referenced
this issue
Mar 14, 2020
valentinsulzer
added a commit
that referenced
this issue
Mar 14, 2020
valentinsulzer
added a commit
that referenced
this issue
Mar 14, 2020
valentinsulzer
added a commit
that referenced
this issue
Mar 14, 2020
As part of this I have moved the particle submodels to all be in the same folder, trying to clear up the submodel structure, is that ok? @Scottmar93 |
valentinsulzer
added a commit
that referenced
this issue
Mar 14, 2020
8 tasks
valentinsulzer
added a commit
that referenced
this issue
Mar 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We should allow for Broadcasts onto cell edges if required by the spatial method. This is needed e.g. for
fast_diffusion
, inconstant_stefan_maxwell_diffusion
and inisothermal
models. At the moment these all broadcast zero flux to the appropriate domain, but this ends up being evaluated on cell centers, not edges.The text was updated successfully, but these errors were encountered: