Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broadcast to cell edges #609

Closed
rtimms opened this issue Sep 5, 2019 · 1 comment · Fixed by #891
Closed

Broadcast to cell edges #609

rtimms opened this issue Sep 5, 2019 · 1 comment · Fixed by #891
Assignees

Comments

@rtimms
Copy link
Contributor

rtimms commented Sep 5, 2019

We should allow for Broadcasts onto cell edges if required by the spatial method. This is needed e.g. for fast_diffusion, in constant_stefan_maxwell_diffusion and in isothermal models. At the moment these all broadcast zero flux to the appropriate domain, but this ends up being evaluated on cell centers, not edges.

@valentinsulzer
Copy link
Member

As part of this I have moved the particle submodels to all be in the same folder, trying to clear up the submodel structure, is that ok? @Scottmar93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants