-
-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offset start time when stepping #2760
Comments
Is it better to offset time by a small number, save only parts |
valentinsulzer
added a commit
that referenced
this issue
Mar 10, 2023
valentinsulzer
added a commit
that referenced
this issue
Mar 13, 2023
valentinsulzer
added a commit
that referenced
this issue
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, when solving a simulation by stepping, the final time step of the old solution (e.g.
[0,0.01 ..., 1]
) is the same as the first time step of the next solution (e.g.[1,1.01,...]
). We get around this by excluding the first time step of the next solution when constructing the full solution ([0,0.01,...,1,1.01,...]
). However, this means that the solution naively constructed by concatenating together all the steps is different from the solution as constructed by PyBaMM. Instead, we should offset the start of each step by a relevant small number (e.g.1e-6
) and then keep the first step.The text was updated successfully, but these errors were encountered: