Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPM(e) with SEI growth or lithium plating #2098

Closed
brosaplanella opened this issue Jun 9, 2022 · 0 comments · Fixed by #2099
Closed

SPM(e) with SEI growth or lithium plating #2098

brosaplanella opened this issue Jun 9, 2022 · 0 comments · Fixed by #2099
Assignees
@brosaplanella

Comments

@brosaplanella
Copy link
Member

At the moment we average the SEI growth, lithium plating and porosity submodels for Single Particle Models. They don't need to be averaged (preprint available in arXiv very soon), so we should change the default.

This probably applies to crack and LAM submodels too, but I have not proved it so I will leave them as they are.
@brosaplanella brosaplanella self-assigned this Jun 9, 2022
brosaplanella added a commit that referenced this issue Jun 9, 2022
@brosaplanella
#2098 change averaging for SPMe+SR
5366245
@brosaplanella brosaplanella mentioned this issue Jun 9, 2022
Merged
8 tasks
brosaplanella added a commit that referenced this issue Jun 9, 2022
@brosaplanella
#2098 fix tests
006bf2f
brosaplanella added a commit that referenced this issue Jun 9, 2022
@brosaplanella
#2098 fix citation test
9fe04f2
brosaplanella added a commit that referenced this issue Jul 27, 2022
@brosaplanella
#2098 make SPM default x-averaged side reactions
f7966b5
brosaplanella added a commit that referenced this issue Jul 27, 2022
@brosaplanella
#2098 fix MPM tests issue
535bd14
brosaplanella added a commit that referenced this issue Jul 27, 2022
@brosaplanella
#2098 update CHANGELGO
d7edf6f
brosaplanella added a commit that referenced this issue Jul 27, 2022
@brosaplanella
Merge pull request #2099 from pybamm-team/issue-2098-SPMe-SR
dfe6a46 
#2098 change averaging for SPMe+SR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brosaplanella brosaplanella

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#2098 change averaging for SPMe+SR pybamm-team/PyBaMM
1 participant
@brosaplanella