Skip to content

Commit

Permalink
fix lead-acid tests
Browse files Browse the repository at this point in the history
  • Loading branch information
valentinsulzer committed Feb 19, 2023
1 parent c1780c6 commit 9dfe43a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pybamm/input/parameters/lithium_ion/OKane2022.py
Original file line number Diff line number Diff line change
Expand Up @@ -614,7 +614,7 @@ def get_parameter_values():
"Negative electrode number of cracks per unit area [m-2]": 3180000000000000.0,
"Negative electrode Paris' law constant b": 1.12,
"Negative electrode Paris' law constant m": 2.2,
"Negative electrode cracking rate": graphite_cracking_rate_Ai2020,
"Negative electrode cracking rate [m.s-1]": graphite_cracking_rate_Ai2020,
"Negative electrode LAM constant proportional term [s-1]": 2.7778e-07,
"Negative electrode LAM constant exponential term": 2.0,
"Negative electrode critical stress [Pa]": 60000000.0,
Expand Down Expand Up @@ -649,7 +649,7 @@ def get_parameter_values():
"Positive electrode number of cracks per unit area [m-2]": 3180000000000000.0,
"Positive electrode Paris' law constant b": 1.12,
"Positive electrode Paris' law constant m": 2.2,
"Positive electrode cracking rate": cracking_rate_Ai2020,
"Positive electrode cracking rate [m.s-1]": cracking_rate_Ai2020,
"Positive electrode LAM constant proportional term [s-1]": 2.7778e-07,
"Positive electrode LAM constant exponential term": 2.0,
"Positive electrode critical stress [Pa]": 375000000.0,
Expand Down
1 change: 1 addition & 0 deletions pybamm/parameters/lead_acid_parameters.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ def _set_parameters(self):
self.c_e_init = pybamm.Parameter(
"Initial concentration in electrolyte [mol.m-3]"
)
self.c_e_init_av = self.c_e_init
self.V_w = pybamm.Parameter("Partial molar volume of water [m3.mol-1]")
self.V_plus = pybamm.Parameter("Partial molar volume of cations [m3.mol-1]")
self.V_minus = pybamm.Parameter("Partial molar volume of anions [m3.mol-1]")
Expand Down

0 comments on commit 9dfe43a

Please sign in to comment.