Skip to content

Commit

Permalink
#2338 fix integration tests
Browse files Browse the repository at this point in the history
  • Loading branch information
brosaplanella committed Nov 3, 2022
1 parent d6e5a87 commit 4941a33
Show file tree
Hide file tree
Showing 2 changed files with 32 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,14 @@ def test_sei_reaction_limited(self):

def test_sei_asymmetric_reaction_limited(self):
options = {"SEI": "reaction limited (asymmetric)"}
self.run_basic_processing_test(options)
parameter_values = pybamm.ParameterValues("Xu2019")
parameter_values.update(
{
"SEI growth transfer coefficient": 0.2
},
check_already_exists=False,
)
self.run_basic_processing_test(options, parameter_values=parameter_values)

def test_sei_solvent_diffusion_limited(self):
options = {"SEI": "solvent-diffusion limited"}
Expand All @@ -75,7 +82,14 @@ def test_sei_ec_reaction_limited(self):

def test_sei_asymmetric_ec_reaction_limited(self):
options = {"SEI": "ec reaction limited (asymmetric)"}
self.run_basic_processing_test(options)
parameter_values = pybamm.ParameterValues("Xu2019")
parameter_values.update(
{
"SEI growth transfer coefficient": 0.2
},
check_already_exists=False,
)
self.run_basic_processing_test(options, parameter_values=parameter_values)

def test_constant_utilisation(self):
options = {"interface utilisation": "constant"}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,14 @@ def test_sei_reaction_limited(self):

def test_sei_asymmetric_reaction_limited(self):
options = {"SEI": "reaction limited (asymmetric)"}
self.run_basic_processing_test(options)
parameter_values = pybamm.ParameterValues("Xu2019")
parameter_values.update(
{
"SEI growth transfer coefficient": 0.2
},
check_already_exists=False,
)
self.run_basic_processing_test(options, parameter_values=parameter_values)

def test_sei_solvent_diffusion_limited(self):
options = {"SEI": "solvent-diffusion limited"}
Expand All @@ -197,7 +204,14 @@ def test_sei_asymmetric_ec_reaction_limited(self):
"SEI": "ec reaction limited (asymmetric)",
"SEI porosity change": "true",
}
self.run_basic_processing_test(options)
parameter_values = pybamm.ParameterValues("Xu2019")
parameter_values.update(
{
"SEI growth transfer coefficient": 0.2
},
check_already_exists=False,
)
self.run_basic_processing_test(options, parameter_values=parameter_values)

def test_loss_active_material_stress_negative(self):
options = {"loss of active material": ("none", "stress-driven")}
Expand Down

0 comments on commit 4941a33

Please sign in to comment.