Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove orientation method from supportsOrientation #77

Merged
merged 1 commit into from
Dec 31, 2020

Conversation

tlambert03
Copy link
Member

pulling out the orientation getter/setter implementation from the Protocol (didn't belong there)

@codecov
Copy link

codecov bot commented Dec 31, 2020

Codecov Report

Merging #77 (2a5babc) into master (cb0c2f4) will increase coverage by 0.32%.
The diff coverage is 92.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
+ Coverage   87.54%   87.87%   +0.32%     
==========================================
  Files          15       15              
  Lines        1614     1616       +2     
==========================================
+ Hits         1413     1420       +7     
+ Misses        201      196       -5     
Impacted Files Coverage Δ
magicgui/widgets/_bases.py 89.79% <91.66%> (+<0.01%) ⬆️
magicgui/widgets/_protocols.py 76.28% <100.00%> (+1.28%) ⬆️
magicgui/backends/_qtpy/widgets.py 84.45% <0.00%> (+0.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb0c2f4...39b2014. Read the comment docs.

@tlambert03 tlambert03 merged commit aef08dd into pyapp-kit:master Dec 31, 2020
@tlambert03 tlambert03 deleted the move-orientation-mixin branch December 31, 2020 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant