Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add range slider (take 2) #455

Merged
merged 6 commits into from
Oct 21, 2022
Merged

Conversation

tlambert03
Copy link
Member

a slightly more minimal take on adding range slider. This doesn't worry about using superqt's labeled sliders, just implements a range slider.

cc @brisvag, I added you as a co-author

closes #337

tlambert03 and others added 2 commits October 3, 2022 19:00
Co-authored-by: Lorenzo Gaifas <brisvag@gmail.com>
@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Merging #455 (8de3204) into main (f34bb42) will increase coverage by 0.05%.
The diff coverage is 94.44%.

❗ Current head 8de3204 differs from pull request most recent head 80110b2. Consider uploading reports for the commit 80110b2 to get more accurate results

@@            Coverage Diff             @@
##             main     #455      +/-   ##
==========================================
+ Coverage   87.77%   87.82%   +0.05%     
==========================================
  Files          31       31              
  Lines        4113     4156      +43     
==========================================
+ Hits         3610     3650      +40     
- Misses        503      506       +3     
Impacted Files Coverage Δ
magicgui/backends/_qtpy/__init__.py 100.00% <ø> (ø)
magicgui/widgets/__init__.py 100.00% <ø> (ø)
magicgui/backends/_qtpy/widgets.py 87.01% <90.62%> (+0.06%) ⬆️
magicgui/widgets/_bases/__init__.py 100.00% <100.00%> (ø)
magicgui/widgets/_bases/ranged_widget.py 88.88% <100.00%> (+0.95%) ⬆️
magicgui/widgets/_bases/slider_widget.py 96.66% <100.00%> (+0.23%) ⬆️
magicgui/widgets/_concrete.py 86.83% <100.00%> (+0.10%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tlambert03
Copy link
Member Author

looks like the tests here will need superqt v0.3.6 ... which is in prerelease now. will update in a week or so

@brisvag
Copy link
Contributor

brisvag commented Oct 4, 2022

Awesome! So the issue we were having with signals emitting/receeving the wrong types is solved?

@tlambert03 tlambert03 added the enhancement New feature or request label Oct 21, 2022
@tlambert03 tlambert03 merged commit 3583a30 into pyapp-kit:main Oct 21, 2022
@tlambert03 tlambert03 deleted the range-slider-2 branch October 21, 2022 20:52
@tlambert03 tlambert03 mentioned this pull request Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants