Make call_button public #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks @dstansby. just some outdated tests left that need fixing. |
tlambert03
reviewed
Mar 29, 2022
magicgui/widgets/_function_gui.py
Outdated
| @@ -186,23 +187,23 @@ def __init__( | |||
|
|
|||
| if call_button is None: | |||
| call_button = not auto_call | |||
| self._call_button: PushButton | None = None | |||
| self.call_button: PushButton | None = None | |||
There was a problem hiding this comment.
actually, i might prefer a public accessor rather than changing the private attr.
@property
def call_button(self) -> Optional[PushButton]:
return self._call_button
Codecov Report
@@ Coverage Diff @@
## main #391 +/- ##
=======================================
Coverage 88.61% 88.61%
=======================================
Files 30 30
Lines 3793 3796 +3
=======================================
+ Hits 3361 3364 +3
Misses 432 432
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/napari/magicgui/issues/381#issuecomment-1060550957 and associated discussion. This allows public access to the button automatically created by
magicguiso it can be modified after creating the GUI.