Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #456
needed something to procrastinate on for an hour or two this afternoon bc couldn't think about data modeling anymore.
OK so here is a tour of widths on the current homepage:
pyos_widths_pre.mp4
and here is this PR
pyos_widths_post.mp4
so not THAT different but here are the highlights.
masthead.html
are me reformatting the template html a bit with prettier.!important
tags there, where the styles were conflicting with one another. I cleaned it up so all the "top-level" layout stuff of where stuff is on the header bar is inmasthead
and then everything for the dropdown menus was inpyos_dropdown
, and i grouped together definitions for nested classes that were also defined in multiple places so that way we aren't mixing levels and confusing ourselves :). This was for maintenance's sake but also since we are having some perf problems, specifically in the css rendering part, i figure we might as well start to trim down unused/conflicting styles so the first render can start getting a little faster.so i made this breakpoint a bit wider and added some stuff to keep the images from getting humongous when that happened.
anyway i know this is not a modular PR, so if we don't like any of these changes it's no problem to take them out. just once i got started i sorta couldn't stop touchin stuff and here we are