Use list comprehension and pythonic variable names in dry code lesson #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwasser
reviewed
Oct 21, 2024
lwasser
reviewed
Oct 21, 2024
| @@ -132,17 +132,17 @@ to both understand and use. If you need to change the calculation itself, you ca | |||
|
|
|||
| ```python | |||
| temp = 55 | |||
| new_temp = fahr_to_kelvin(fahr = temp) | |||
| new_temp = convert_fahrenheit_to_kelvin(temp) | |||
There was a problem hiding this comment.
I like how expressive these names are. My only concern is they are so long! for the lessons we could do this but in my code I find really long names to make it harder to read too. @willingc do you have any thoughts on this? i love the use of a verb for the function convert_fahr_to_kelv might be a bit shorter
lwasser
approved these changes
Oct 21, 2024
|
let's merge this - i opened #44 to discuss variable name length! it's not a make or break for the workshop. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.