Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidying the homepage a bit - index for lessons #30

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

sneakers-the-rat
Copy link
Contributor

I was a bit confused by the current homepage, since it wasn't clear to me where the lessons were!

Screenshot 2024-10-17 at 8 11 07 PM

Judging from the name of the repo/url, i am assuming that we'll want to have a number of different lessons in here over time? It made sense to me to have those be in the top bar with links out to other pages in the dropdown, so then it becomes clear that i am "in" one lesson or another by the top nav bar, and then the left bar is what part of the lesson i'm a part of. I would think that this whole site is "lessons" so it wasn't immediately obvious to me that i needed to click 'lessons' to go to the clean code lesson.

I also tidied up the rest of the index page, moved the contributors into a badge like the others, and added a card for the lesson like we have on the package guide. I think the header links are a little goofy just hovering in the center, so i aligned them to the left too.

Screenshot 2024-10-17 at 8 09 50 PM

The thing that i wasn't sure about here is whether the "functions conditionals and checks" is a different lesson than "clean, expressive, code" or whether it was a subsection of it? The folder structure says that it's a subsection, but ig the hierarchy there was a little ambiguous to me so lmk if that's supposed to be considered a separate lesson.

@lwasser
Copy link
Member

lwasser commented Oct 18, 2024

@all-contributors please add @sneakers-the-rat for code, review

Copy link
Contributor

@lwasser

I've put up a pull request to add @sneakers-the-rat! 🎉

Copy link
Member

@lwasser lwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, somehow you got the circle CI preview working, too, @sneakers-the-rat THANK YOU so much. I was fighting with that as well. This looks great. Yup - you made a perfect call on the reorg. More lessons are coming, I just haven't had time to get this cleaned up.

@lwasser lwasser merged commit f2a9330 into pyOpenSci:main Oct 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants