Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue in falsify method when no tests were performed #1089

Merged
merged 1 commit into from
Dec 3, 2023
Merged

Conversation

bloebp
Copy link
Member

@bloebp bloebp commented Nov 30, 2023

It now does not raise a division by zero error anymore. Other changes:

  • Add new parameter indicating whether the method requires data for all nodes in the graph or also allows a subset of data.
  • If no tests were performed, the summary now returns "Cannot be evaluated".

It now does not raise a division by zero error anymore. Other changes:
- Add new parameter indicating whether the method requires data for all nodes in the graph or also allows a subset of data.
- If no tests were performed, the summary now returns "Cannot be evaluated".

Signed-off-by: Patrick Bloebaum <bloebp@amazon.com>
Copy link
Member

@amit-sharma amit-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bloebp bloebp merged commit 1df8561 into main Dec 3, 2023
30 checks passed
@bloebp bloebp deleted the fix_falsify branch December 3, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants