Fix issue with linear regressor with fixed parameters #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bloebp
force-pushed
the
fix_auto_assign_classif
branch
from
041d5ab to
0ed0efd
Compare
bloebp
force-pushed
the
fixed_linear_regression
branch
from
b041898 to
c6a7667
Compare
bloebp
force-pushed
the
fix_auto_assign_classif
branch
2 times, most recently
from
60a2c2e to
f00efd2
Compare
bloebp
force-pushed
the
fixed_linear_regression
branch
from
c6a7667 to
1690081
Compare
petergtz
previously approved these changes
Nov 10, 2023
bloebp
force-pushed
the
fix_auto_assign_classif
branch
from
f00efd2 to
34d3a87
Compare
Before, when creating a linear regressor with fixed parameters, these parameters are overridden when fit to data. Now, the parameters remain fixed. Signed-off-by: Patrick Bloebaum <bloebp@amazon.com>
bloebp
force-pushed
the
fixed_linear_regression
branch
from
1690081 to
21fba9f
Compare
petergtz
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, when creating a linear regressor with fixed parameters, the parameters would be overridden upon fitting to data. Now, the parameters remain fixed.