Fix incorrect signed noise terms for DiscreteAdditiveNoiseModel

Signed-off-by: Gregory Saldanha <gsaldanha2@gmail.com>
py-why · Oct 22, 2024 · b17f2c3 · b17f2c3
1 parent 4bf7d30
commit b17f2c3
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/dowhy/gcm/causal_mechanisms.py b/dowhy/gcm/causal_mechanisms.py
@@ -232,7 +232,7 @@ def fit(self, X: np.ndarray, Y: np.ndarray) -> None:
         Y = Y.astype(np.int32)
 
         self._prediction_model.fit(X=X, Y=Y)
-        self._noise_model.fit(self._rounded_prediction(X) - Y)
+        self._noise_model.fit(Y - self._rounded_prediction(X))
 
     def evaluate(self, parent_samples: np.ndarray, noise_samples: np.ndarray) -> np.ndarray:
         if not is_discrete(noise_samples):