Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrected typos in the references #713

Merged
merged 23 commits into from
Jul 20, 2023
Merged

Corrected typos in the references #713

merged 23 commits into from
Jul 20, 2023

Conversation

star1327p
Copy link
Contributor

No description provided.

@fverac
Copy link
Collaborator

fverac commented Jul 19, 2023

Thanks for the typo corrections! Can you update your branch to include the latest changes from main? Then I can approve the PR

@star1327p
Copy link
Contributor Author

star1327p commented Jul 19, 2023 •
edited
Loading

@fverac I have updated the branch to include the latest changes from main. But the DCO check failed probably because I am using the web version.

@fverac
Copy link
Collaborator

fverac commented Jul 19, 2023 •
edited
Loading

@fverac I have updated the branch to include the latest changesfrom main. But the DCO check failed probably because I am using the web version.

Yes, I see that. I believe if you follow the instructions in the "Details" link next to the DCO check failure it should walk you through how to retroactively sign off on your commits.

star1327p and others added 22 commits July 19, 2023 15:29
@star1327p
Corrected typos in the references
315047d 
Signed-off-by: star1327p <star1327p@gmail.com>
@kbattocchi @star1327p
Refactor DynamicDML to remove incompatible method signatures
91c1aaa 
Signed-off-by: star1327p <star1327p@gmail.com>
@kbattocchi @star1327p
Enable GitHub Actions
4eaefdd 
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
Signed-off-by: star1327p <star1327p@gmail.com>
@kbattocchi @star1327p
Update developer documentation
b92fdc4 
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
Signed-off-by: star1327p <star1327p@gmail.com>
@kbattocchi @star1327p
Update copyright and links to point to PyWhy
cb327c1 
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
Signed-off-by: star1327p <star1327p@gmail.com>
@kbattocchi @star1327p
Fix status checks in CI workflow
c63a2d1 
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
Signed-off-by: star1327p <star1327p@gmail.com>
@kbattocchi @star1327p
Fix py-why#760
c865365 
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
Signed-off-by: star1327p <star1327p@gmail.com>
@kbattocchi @star1327p
Enable compatability with pandas 2.0
ab3e295 
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
Signed-off-by: star1327p <star1327p@gmail.com>
@kbattocchi @star1327p
Bump supported shap version limit
44f0dbe 
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
Signed-off-by: star1327p <star1327p@gmail.com>
@kbattocchi @star1327p
Use verbose pip install when debugging workflows
edeafb5 
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
Signed-off-by: star1327p <star1327p@gmail.com>
@kbattocchi @star1327p
Fix numpy 1.24 compatibility
521d5a1 
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
Signed-off-by: star1327p <star1327p@gmail.com>
@fverac @kbattocchi @star1327p
remove azure pipelines link from README (py-why#771)
5d390c4 
Update build badge

Signed-off-by: Fabio Vera <fabiovera@microsoft.com>
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
Co-authored-by: Keith Battocchi <kebatt@microsoft.com>
Signed-off-by: star1327p <star1327p@gmail.com>
@kbattocchi @star1327p
Prepare 0.14.1 release (py-why#770)
86e6be9 
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
Signed-off-by: star1327p <star1327p@gmail.com>
@kbattocchi @star1327p
Get datasets from web instead of blob
b0858eb 
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
Signed-off-by: star1327p <star1327p@gmail.com>
@kbattocchi @star1327p
Generate code coverage report
a7654c1 
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
Signed-off-by: star1327p <star1327p@gmail.com>
@kbattocchi @star1327p
Improve abstract method coverage approach
58a98e2 
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
Signed-off-by: star1327p <star1327p@gmail.com>
@kbattocchi @star1327p
Use lkg requirements for PRs
ba54997 
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
Signed-off-by: star1327p <star1327p@gmail.com>
@kbattocchi @star1327p
Fix website publish authentication
097d2b2 
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
Signed-off-by: star1327p <star1327p@gmail.com>
@kbattocchi @star1327p
Propagate lkg flag to sub-workflows
484e0ac 
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
Signed-off-by: star1327p <star1327p@gmail.com>
@kbattocchi @star1327p
Work around GitHub Actions runner issue
78ddb80 
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
Signed-off-by: star1327p <star1327p@gmail.com>
@fverac @star1327p
Add links to PyWhy website and Discord (py-why#788)
9c568e4 
Signed-off-by: star1327p <star1327p@gmail.com>
@kbattocchi @star1327p
Pin cython<3
0ccae86 
Signed-off-by: Keith Battocchi <kebatt@microsoft.com>
Signed-off-by: star1327p <star1327p@gmail.com>
@star1327p star1327p force-pushed the references-update branch from 2604ae4 to 0ccae86 Compare July 19, 2023 22:30
@star1327p
Copy link
Contributor Author

@fverac I have updated the branch to include the latest changesfrom main. But the DCO check failed probably because I am using the web version.

Yes, I see that. I believe if you follow the instructions in the "Details" link next to the DCO check failure it should walk you through how to retroactively sign off on your commits.

@fverac I have fixed the DCO issue, and now the DCO check has succeeded.

@fverac fverac merged commit ce0066c into py-why:main Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fverac fverac fverac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@star1327p @fverac @kbattocchi