Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add matplotlib version ceiling #680

Merged
merged 3 commits into from
Sep 20, 2022
Merged

add matplotlib version ceiling #680

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
254dc57
add matplotlib version ceiling
fverac Sep 20, 2022
f183c21
Merge branch 'main' into fverac/cap_matplotlib_version
fverac Sep 20, 2022
5b2ebf4
complete matplotlib cap
fverac Sep 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,8 @@ tf =
protobuf < 4
plt =
graphviz
matplotlib
; Version capped due to shap incompatibility
matplotlib < 3.6.0
dowhy =
dowhy < 0.9
all =
Expand All @@ -69,7 +70,8 @@ all =
tensorflow > 1.10, < 2.3
; Version capped due to tensorflow incompatibility
protobuf < 4
matplotlib
; Version capped due to shap incompatibility
matplotlib < 3.6.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using

Suggested change
matplotlib < 3.6.0
matplotlib != 3.6.0

if this seems like a matplotlib issue that will be fixed soon.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem like matplotlib plans to address this judging by this issue:

matplotlib/matplotlib#23924

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that whatever change you make here, the same change should also be made to the plt extra.

dowhy < 0.9

[options.packages.find]
Expand Down