Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create panel subpackage #662

Merged
merged 1 commit into from
Nov 15, 2022
Merged

Create panel subpackage #662

merged 1 commit into from
Nov 15, 2022

Conversation

kbattocchi
Copy link
Collaborator

This creates an econml.panel package, adds a few utilities to it, and moves DynamicDML from econml.dynamic.dml to econml.panel.dml

@kbattocchi kbattocchi force-pushed the kebatt/dynamicToPanel branch 2 times, most recently from 1ee872f to 50a2a9a Compare August 13, 2022 12:02
@kbattocchi kbattocchi force-pushed the kebatt/dynamicToPanel branch 2 times, most recently from b0dd88e to 221aec3 Compare September 14, 2022 21:13
@kbattocchi kbattocchi requested a review from fverac September 15, 2022 13:36
@fverac
Copy link
Collaborator

fverac commented Sep 15, 2022

Do we want to restructure/relabel some of our docs now to include a panel section?

I believe at the moment we currently have a "Dynamic Treatment Regime" section, but maybe that can be housed under a broader "Panel Data" section?
https://econml.azurewebsites.net/spec/estimation_dynamic.html

@kbattocchi kbattocchi force-pushed the kebatt/dynamicToPanel branch from 221aec3 to 714c6b5 Compare October 31, 2022 19:21
econml/panel/utilities.py Outdated Show resolved Hide resolved
@fverac
Copy link
Collaborator

fverac commented Nov 2, 2022

Do we want to restructure/relabel some of our docs now to include a panel section?

I believe at the moment we currently have a "Dynamic Treatment Regime" section, but maybe that can be housed under a broader "Panel Data" section? https://econml.azurewebsites.net/spec/estimation_dynamic.html

Bumping this. It seems to me like it could be worthwhile to rename the "Estimation Methods for Dynamic Treatment Regimes" section in our docs to something like "Estimation Methods for Panel Data" in here since this PR is sort of prepping for future panel methods.

@kbattocchi
Copy link
Collaborator Author

I've renamed the documentation section as suggested.

@kbattocchi kbattocchi force-pushed the kebatt/dynamicToPanel branch from 714c6b5 to d5691f4 Compare November 15, 2022 13:52
@kbattocchi kbattocchi enabled auto-merge (rebase) November 15, 2022 13:53
@kbattocchi kbattocchi merged commit 5ce30d2 into main Nov 15, 2022
@kbattocchi kbattocchi deleted the kebatt/dynamicToPanel branch November 15, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants