Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Scripts/booklet.py. #469

Merged
merged 1 commit into from
Apr 9, 2022
Merged

Add Scripts/booklet.py. #469

merged 1 commit into from
Apr 9, 2022

Conversation

avm
Copy link
Contributor

@avm avm commented Nov 14, 2018

A script to create centerfold brochures/booklets, similar to bookletcreator.com.

@MartinThoma
Copy link
Member

Thank you for the contribution!

I'm uncertain if such script should be part of this repository. Adding it would mean we need to maintain it. It's not shipped with PyPDF2 (the PyPI package) anyway, hence I tend to not have the scripts here at all.

Maybe having a PyPDF2-contributions repository or similar would make sense?

@MartinThoma MartinThoma added the needs-discussion The PR/issue needs more discussion before we can continue label Apr 6, 2022
@avm
Copy link
Contributor Author

avm commented Apr 6, 2022

Whatever suits you best. I saw Scripts/2-up.py in the repo and thought that maybe booklet.py belongs there too, but I guess I can keep it to myself :-).

@MartinThoma
Copy link
Member

I've just became a maintainer yesterday, so give me a bit of time to organize stuff :-) I'll come back 🤞

@MartinThoma MartinThoma merged commit 67439ed into py-pdf:master Apr 9, 2022
@MartinThoma
Copy link
Member

Thank you for your contribution!

MartinThoma added a commit that referenced this pull request Apr 10, 2022
- PKG: Make Tests not a subpackage (#728)
- BUG: Fix ASCII85Decode.decode assertion (#729)
- BUG: Error in Chinese character encoding (#463)
- BUG: Code duplication in Scripts/2-up.py
- ROBUST: Guard 'obj.writeToStream' with 'if obj is not None'
- ROBUST: Ignore a /Prev entry with the value 0 in the trailer
- MAINT: Remove Sample_Code (#726)
- TST: Close file handle in test_writer (#722)
- TST: Fix test_get_images (#730)
- DEV: Make tox use pytest and add more Python versions (#721)
- DOC: Many (#720, #723-725, #469)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-discussion The PR/issue needs more discussion before we can continue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants