Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP: Update to deprecation_no_replacement #2943

Merged
merged 3 commits into from
Nov 15, 2024
Merged

Conversation

j-t-1
Copy link
Contributor

@j-t-1 j-t-1 commented Nov 15, 2024

Change deprecate_no_replacement to deprecation_no_replacement.

Change deprecate_no_replacement to deprecation_no_replacement.
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.41%. Comparing base (c855be0) to head (810667b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2943   +/-   ##
=======================================
  Coverage   96.41%   96.41%           
=======================================
  Files          52       52           
  Lines        8749     8749           
  Branches     1591     1591           
=======================================
  Hits         8435     8435           
  Misses        186      186           
  Partials      128      128           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefan6419846
Copy link
Collaborator

Thanks for your PR. Please explain why this change is relevant here. Additionally, while only being small, the stream.write change does not belong to this PR.

@j-t-1
Copy link
Contributor Author

j-t-1 commented Nov 15, 2024

When we moved to 5.0.0 the deprecate line was not updated. I can revert the stream.write.

Change deprecate_no_replacement to deprecation_no_replacement.
@stefan6419846 stefan6419846 merged commit 03f7140 into py-pdf:main Nov 15, 2024
16 checks passed
@j-t-1 j-t-1 deleted the OutlineItem branch November 15, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants