Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STY: Refactor _xobj_to_image #2863

Merged
merged 3 commits into from
Sep 22, 2024
Merged

STY: Refactor _xobj_to_image #2863

merged 3 commits into from
Sep 22, 2024

Commits on Sep 22, 2024

  1. STY: Refactor _xobj_to_image 

    * Create _apply_decode and move it to _xobj_image_helpers
* Create _get_mode_and_invert_color and move it to _xobj_image_helpers
* Create _apply_alpha as an inner function as it's calling _xobj_to_image

This reduced the Cyclomatic Complexity from 44 to 19
    @MartinThoma
    MartinThoma committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    babcc07 View commit details
    Browse the repository at this point in the history

  2. Comment formatting

    @MartinThoma
    MartinThoma committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    fb99f9d View commit details
    Browse the repository at this point in the history

  3. Fix

    @MartinThoma
    MartinThoma committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    420f3b1 View commit details
    Browse the repository at this point in the history