Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROB: tolerate comments in arrays #2856

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

pubpub-zz
Copy link
Collaborator

closes #2843

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@c4cdb5c). Learn more about missing BASE report.
Report is 87 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2856   +/-   ##
=======================================
  Coverage        ?   95.99%           
=======================================
  Files           ?       51           
  Lines           ?     8512           
  Branches        ?     1699           
=======================================
  Hits            ?     8171           
  Misses          ?      200           
  Partials        ?      141           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pubpub-zz
Copy link
Collaborator Author

@stefan6419846
the previous commit did not upload its coverage report preventing comparison but the new coverage is available. I've checked the patch coverage manually and we are at 100%

please review and commit this PR first, I hope it will fix #2857 coverage

@stefan6419846 stefan6419846 merged commit 7e4a0d6 into py-pdf:main Sep 19, 2024
16 checks passed
pubpub-zz added a commit to pubpub-zz/pypdf that referenced this pull request Sep 29, 2024
## Version 5.0.1, 2024-09-29

### New Features (ENH)
- Add `full` parameter to PdfWriter constructor (py-pdf#2865)

### Bug Fixes (BUG)
- Update pyproject.toml with minimum Python version of 3.8 (py-pdf#2859)
- Cope with unbalanced delimiters in dictionary object (py-pdf#2878)
- Cope with encoding with too many differences (py-pdf#2873)
- Missing spaces in extract_text() method (py-pdf#1328) (py-pdf#2868)
- Tolerate truncated files and no warning when jumping startxref (py-pdf#2855)

### Robustness (ROB)
- Repair PDF with invalid Root object (py-pdf#2880)
- Continue parsing dictionary object when error is detected (py-pdf#2872)
- Merge documents with invalid pages in named destinations (py-pdf#2857)
- Tolerate comments(%) in arrays (py-pdf#2856)

### Documentation (DOC), Testing (TST), Code Style (STY), Developer Experience (DEV), Maintenance (MAINT)

- (py-pdf#2844), (py-pdf#2862), (py-pdf#2863), (py-pdf#2847), (py-pdf#2860), (py-pdf#2867), (py-pdf#2874), (py-pdf#2879)

[Full Changelog](py-pdf/pypdf@5.0.0...5.0.1)
@pubpub-zz pubpub-zz mentioned this pull request Sep 29, 2024
pubpub-zz added a commit that referenced this pull request Sep 29, 2024
## Version 5.0.1, 2024-09-29

### New Features (ENH)
- Add `full` parameter to PdfWriter constructor (#2865)

### Bug Fixes (BUG)
- Update pyproject.toml with minimum Python version of 3.8 (#2859)
- Cope with unbalanced delimiters in dictionary object (#2878)
- Cope with encoding with too many differences (#2873)
- Missing spaces in extract_text() method (#1328) (#2868)
- Tolerate truncated files and no warning when jumping startxref (#2855)

### Robustness (ROB)
- Repair PDF with invalid Root object (#2880)
- Continue parsing dictionary object when error is detected (#2872)
- Merge documents with invalid pages in named destinations (#2857)
- Tolerate comments in arrays (#2856)

### Developer Experience (DEV)
- Use latest Python version for benchmarking (#2879)

### Maintenance (MAINT)
- Add tests to source distributions (#2874)
- Refactor _update_field_annotation (#2862)

[Full Changelog](5.0.0...5.0.1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#4 Using PdfReader causes a crash
2 participants