Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance Testing #761

Closed
MartinThoma opened this issue Apr 15, 2022 · 0 comments
Closed

Performance Testing #761

MartinThoma opened this issue Apr 15, 2022 · 0 comments
Labels
nf-ci Non-functional change: Continuous Integration nf-performance Non-functional change: Performance

Comments

@MartinThoma
Copy link
Member

Performance is important for many users of PyPDF2. For this reason we should introduce some kind of performance testing.

I would approach it like this:

  1. Identify typical workloads where performance might be / become an issue.
  2. Create a benchmark. This includes scenarios (e.g. doing something with one big file vs doing something often)
  3. Define a baseline scenario for which we measure the time. All other times are just relative to the baseline (e.g. 1.78x the baseline). The baseline should be something that is unlikely to change a lot. By this relative approach we hopefully get rid of machine differences
@MartinThoma MartinThoma added nf-performance Non-functional change: Performance nf-ci Non-functional change: Continuous Integration labels Apr 15, 2022
MartinThoma added a commit that referenced this issue Apr 19, 2022
MartinThoma added a commit that referenced this issue Apr 19, 2022
MartinThoma added a commit that referenced this issue Apr 19, 2022
MartinThoma added a commit that referenced this issue Apr 19, 2022
MartinThoma added a commit that referenced this issue Apr 19, 2022
VictorCarlquist pushed a commit to VictorCarlquist/PyPDF2 that referenced this issue Apr 29, 2022
We want to track performance over time only for what actually
is in main.

Closes py-pdf#761
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nf-ci Non-functional change: Continuous Integration nf-performance Non-functional change: Performance
Projects
None yet
Development

No branches or pull requests

1 participant