-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sample_Code, Scripts and Tests are wrongly installed as top-level packages #727
Comments
I'm pretty confused by that. This is how the diff between I've added Scripts, Sample_Code, and Tests because I have seen that they were present before. I don't know how they were added before, because they were neither in the Manifest nor there as packages. Is this currently causing issues?
|
When I add it just to the manifest and not as a package, would that lead to the desired result? |
Yes, I suppose it makes sense to include them in sdist but they shouldn't be installed into site-packages. I'm afraid I can't help you figuring out why it worked before, setuptools sdist magic was always totally confusing to me (and I've seen that with my own packages too) but…
…yes, I think adding these directories to |
Only distribute it in the source Closes #727
Only distribute it in the source Closes #727
Only distribute it in the source Closes #727
I've just tried it out locally. Seems to do what is expected. I will make a release today (but probably not within the next 2 hours ... might be in the evening). |
Ok, thanks! |
I can confirm that 1.27.3 looks fine. |
The 2.7.2 release includes a regression where additional top-level packages are wrongly installed, e.g.:
If these files are really supposed to be installed, they should be inside
PyPDF2
and not at top level.The text was updated successfully, but these errors were encountered: