write_html(): homogenization in handling of tag_styles + new optional arg font_family #1217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
@gmischler, @lcgeneralprojects: this PR is ready for review if you want to have a look at it 🙂 I'm wondering if I should try to get rid of |
Lucas-C
force-pushed
the
html-homogenization
branch
from
db9a009 to
c167f59
Compare
Lucas-C
force-pushed
the
html-homogenization
branch
from
c167f59 to
80d01d1
Compare
gmischler
requested changes
Jul 2, 2024
Lucas-C
force-pushed
the
html-homogenization
branch
from
27dbd88 to
8b9d685
Compare
Lucas-C
force-pushed
the
html-homogenization
branch
from
8b9d685 to
a3792ea
Compare
Lucas-C
changed the title
Lucas-C
force-pushed
the
html-homogenization
branch
5 times, most recently
from
66fd0a0 to
2c37f77
Compare
Lucas-C
force-pushed
the
html-homogenization
branch
from
2c37f77 to
1a76aa7
Compare
This was referenced Jul 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up of the clean-up started in PR #1211
Now the following HTML tags are all handled similarly, by the same code blocks in
HTML2FPDF:<b>,<blockquote>,<center>,<code>,<em>,<i>,<dd>,<dt>,<pre>,<strong>,<u>.This PR also introduces a new optional
font_familyparameter toFPDF.write_html(), in order to be able to set the default font family.Checklist:
The GitHub pipeline is OK (green), meaning that both
pylint(static code analyzer) andblack(code formatter) are happy with the changes of this PR.A unit test is covering the code added / modified by this PR
This PR is ready to be merged
[NA] In case of a new feature, docstrings have been added, with also some documentation in the
docs/folder[NA] A mention of the change is present in
CHANGELOG.md